Adds table to dynamic tag logic explanation #1749
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
| @@ -8,7 +8,7 @@ Specifically for versioned products, badges will display differently when the `a | |||
| * `Deprecation planned` (if the lifecycle is deprecated) | |||
|
|
|||
| Example: {applies_to}`stack: deprecated 99.99` | |||
| * `Removal planned` (if the lifecycle is removed) | |||
| * `Removal planned` (if the lifecycle is removed) | |||
There was a problem hiding this comment.
I'd remove these bullets in favor of the table below + kind of rework the content so it's introducing the table instead
|
|
||
| | Lifecycle | Release status | Badge text | | ||
| |-------------|----------------|-----------------------------------------------------------------------------------| | ||
| | preview | prerelease | Planned | |
There was a problem hiding this comment.
these can have examples too. just set the version to 99.99
Comment on lines
18
to
20
| :::{note} | ||
| Visuals and wording in the output documentation are subject to changes and optimizations. | ||
| ::: |
There was a problem hiding this comment.
I'd also move this note down to the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a table to the section that explains the logic of dynamic badges for better understanding.